apoorvmittal10 commented on code in PR #18444:
URL: https://github.com/apache/kafka/pull/18444#discussion_r1913449952
##########
share/src/test/java/org/apache/kafka/server/share/fetch/ShareFetchTest.java:
##########
@@ -87,4 +95,104 @@ public void testFilterErroneousTopicPartitions() {
assertTrue(result.isEmpty());
}
+ @Test
+ @SuppressWarnings("unchecked")
+ public void testMayBeCompleteWithErroneousTopicPartitions() {
Review Comment:
Done.
##########
core/src/main/java/kafka/server/share/SharePartitionManager.java:
##########
@@ -272,9 +285,11 @@ public CompletableFuture<Map<TopicIdPartition,
ShareAcknowledgeResponseData.Part
) {
log.trace("Acknowledge request for topicIdPartitions: {} with groupId:
{}",
acknowledgeTopics.keySet(), groupId);
- this.shareGroupMetrics.shareAcknowledgement();
+
brokerTopicStats.allTopicsStats().totalShareAcknowledgementRequestRate().mark();
Map<TopicIdPartition, CompletableFuture<Throwable>> futures = new
HashMap<>();
acknowledgeTopics.forEach((topicIdPartition,
acknowledgePartitionBatches) -> {
+ // Update share acknowledgement metrics.
+
brokerTopicStats.topicStats(topicIdPartition.topicPartition().topic()).totalShareAcknowledgementRequestRate().mark();
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
