jsancio commented on code in PR #18389:
URL: https://github.com/apache/kafka/pull/18389#discussion_r1913637799


##########
bin/kafka-server-start.sh:
##########
@@ -19,6 +19,14 @@ then
        echo "USAGE: $0 [-daemon] server.properties [--override 
property=value]*"
        exit 1
 fi
+
+for arg in "$@"; do
+    if [[ "$arg" == *.properties ]]; then
+        [[ "$arg" == *"config/kraft"* ]] && echo "Warning: If using default 
properties file, config/kraft path has been deprecated"
+        break
+    fi
+done

Review Comment:
   The breaking change being that `process.roles` must be provided? In 3.x 
`process.roles` was optional but in 4.x that property must be specified since 
ZK is not supported and KRaft is the only valid configuration.
   
   If so, let `KafkaConfig`'s schema validation catch invalid configurations 
and warn the user.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to