[
https://issues.apache.org/jira/browse/KAFKA-18495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17912642#comment-17912642
]
Matthias J. Sax commented on KAFKA-18495:
-----------------------------------------
[~swikarpat] Thanks for filing this ticket. I am not sure if we actually need a
KIP for this... It's a corner case... Given that you already wrote it up, we
might just move to a VOTE directly, skipping the DISCUSSION. – However, we need
to keep the metric until 5.0 is released. We cannot do it in 4.0.1 as you put
on the KIP wiki page (if we would do it in 4.0.1, we could have done it right
away in 4.0.0 to begin with – the whole point of backward compatibility is to
only remove stuff in major release).
[~cadonna] – Thoughts?
> Remove Invalid 'numberOfOpenFiles' Metric from RocksDB State Store
> -------------------------------------------------------------------
>
> Key: KAFKA-18495
> URL: https://issues.apache.org/jira/browse/KAFKA-18495
> Project: Kafka
> Issue Type: Sub-task
> Components: streams
> Reporter: Swikar Patel
> Assignee: Swikar Patel
> Priority: Major
>
> The `numberOfOpenFiles` metric in the Kafka Streams RocksDB state store
> implementation is currently invalid and should be removed.
> This metric was intended to report the approximate number of open files in
> the RocksDB instance. It was previously calculated using the RocksDB internal
> metric `NO_FILE_CLOSES`, which was removed in RocksDB version 7.9.3. Due to
> this change, the `numberOfOpenFiles` metric no longer provides accurate
> information. The current workaround is to have it always return -1, which is
> misleading.
> The `numberOfOpenFiles` metric is: Invalid It does not reflect the actual
> number of open files in RocksDB. This misleading and returning -1 can confuse
> users and monitoring systems and unnecessary it provides no useful
> information in its current state.
> h4. Proposed Solution
> This Jira issue is to implement the changes proposed in KIP. The solution is
> to completely remove the `opennumberfiles` metric, including:
> * Removing the related code in `RocksDBMetricsRecorder`
> (`numberOfOpenFilesSensor`, recording logic).
> * Removing the `numberOfOpenFilesSensor` method in `RocksDBMetrics`
> * Updating the Kafka Streams documentation to reflect the metric's removal.
> h4. KIP
> [KIP-1125: Remove Invalid 'numberOfOpenFiles' Metric from RocksDB State
> Store|https://cwiki.apache.org/confluence/display/KAFKA/KIP-1125%3A+Remove+Invalid+%27numberOfOpenFiles%27+Metric+from+RocksDB+State+Store]
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
