ijuma commented on code in PR #18511:
URL: https://github.com/apache/kafka/pull/18511#discussion_r1914003570


##########
build.gradle:
##########
@@ -2861,6 +2861,7 @@ project(':streams:integration-tests') {
   dependencies {
     implementation libs.slf4jApi
 
+    api libs.scalaLibrary

Review Comment:
   `api` is when you want to export the dependency while `implementation` is 
when you do _not_ want to export the dependency. I think we want the latter 
here. We don't return Scala library types from the public API of this module, 
do we?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to