AndrewJSchofield commented on code in PR #18521: URL: https://github.com/apache/kafka/pull/18521#discussion_r1916665819
########## core/src/test/java/kafka/test/api/ShareConsumerTest.java: ########## @@ -1922,6 +1915,37 @@ private void warmup() throws InterruptedException { } } + private void verifyShareGroupStateTopicRecordsProduced() { + try { + TestUtils.waitForCondition(() -> Review Comment: This condition will already be satisfied because it mirrors the `warmup()` method which runs before each test. I think you can remove this as redundant code. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org