bbejeck commented on code in PR #18516:
URL: https://github.com/apache/kafka/pull/18516#discussion_r1916894987
##########
docs/streams/developer-guide/config-streams.html:
##########
@@ -63,8 +63,10 @@
</li>
<li><a class="reference internal"
href="#recommended-configuration-parameters-for-resiliency"
id="id21">Recommended configuration parameters for resiliency</a>
<ul>
- <li><a class="reference internal" href="#acks"
id="id22">acks</a></li>
- <li><a class="reference internal" href="#id2"
id="id23">replication.factor</a></li>
+ <li><a class="reference internal" href="#acks-short"
id="id22">acks</a></li>
+ <li><a class="reference internal"
href="#replication-factor-short" id="id23">replication.factor</a></li>
+ <li><a class="reference internal" href="#min-isr-short"
id="id44">replication.factor</a></li>
Review Comment:
this `li` should be `min.insync.replicas`
##########
docs/streams/developer-guide/config-streams.html:
##########
@@ -63,8 +63,10 @@
</li>
<li><a class="reference internal"
href="#recommended-configuration-parameters-for-resiliency"
id="id21">Recommended configuration parameters for resiliency</a>
<ul>
- <li><a class="reference internal" href="#acks"
id="id22">acks</a></li>
- <li><a class="reference internal" href="#id2"
id="id23">replication.factor</a></li>
+ <li><a class="reference internal" href="#acks-short"
id="id22">acks</a></li>
+ <li><a class="reference internal"
href="#replication-factor-short" id="id23">replication.factor</a></li>
+ <li><a class="reference internal" href="#min-isr-short"
id="id44">replication.factor</a></li>
+ <li><a class="reference internal"
href="#num-standby-replicas-short" id="id45">replication.factor</a></li>
Review Comment:
same here the `li` text should be `num.standby.replicas`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
