frankvicky commented on code in PR #18346:
URL: https://github.com/apache/kafka/pull/18346#discussion_r1917514065
##########
server/src/main/java/org/apache/kafka/server/config/KRaftConfigs.java:
##########
@@ -36,29 +36,27 @@
public class KRaftConfigs {
/** KRaft mode configs */
public static final String PROCESS_ROLES_CONFIG = "process.roles";
- public static final String PROCESS_ROLES_DOC = "The roles that this
process plays: 'broker', 'controller', or 'broker,controller' if it is both. " +
- "This configuration is only applicable for clusters in KRaft
(Kafka Raft) mode (instead of ZooKeeper). Leave this config undefined or empty
for ZooKeeper clusters.";
-
+ public static final String PROCESS_ROLES_DOC = "The roles that this
process plays: 'broker', 'controller', or 'broker,controller' if it is both. ";
+
public static final String INITIAL_BROKER_REGISTRATION_TIMEOUT_MS_CONFIG =
"initial.broker.registration.timeout.ms";
public static final int INITIAL_BROKER_REGISTRATION_TIMEOUT_MS_DEFAULT =
60000;
public static final String INITIAL_BROKER_REGISTRATION_TIMEOUT_MS_DOC =
"When initially registering with the controller quorum, the number of
milliseconds to wait before declaring failure and exiting the broker process.";
public static final String BROKER_HEARTBEAT_INTERVAL_MS_CONFIG =
"broker.heartbeat.interval.ms";
public static final int BROKER_HEARTBEAT_INTERVAL_MS_DEFAULT = 2000;
- public static final String BROKER_HEARTBEAT_INTERVAL_MS_DOC = "The length
of time in milliseconds between broker heartbeats. Used when running in KRaft
mode.";
+ public static final String BROKER_HEARTBEAT_INTERVAL_MS_DOC = "The length
of time in milliseconds between broker heartbeats.";
public static final String BROKER_SESSION_TIMEOUT_MS_CONFIG =
"broker.session.timeout.ms";
public static final int BROKER_SESSION_TIMEOUT_MS_DEFAULT = 9000;
- public static final String BROKER_SESSION_TIMEOUT_MS_DOC = "The length of
time in milliseconds that a broker lease lasts if no heartbeats are made. Used
when running in KRaft mode.";
+ public static final String BROKER_SESSION_TIMEOUT_MS_DOC = "The length of
time in milliseconds that a broker lease lasts if no heartbeats are made.";
public static final String NODE_ID_CONFIG = "node.id";
public static final int EMPTY_NODE_ID = -1;
- public static final String NODE_ID_DOC = "The node ID associated with the
roles this process is playing when <code>process.roles</code> is non-empty. " +
- "This is required configuration when running in KRaft mode.";
+ public static final String NODE_ID_DOC = "The node ID associated with the
roles this process is playing when <code>process.roles</code> is non-empty.";
Review Comment:
We should keep the statement indicating this is a required configuration.
##########
server/src/main/java/org/apache/kafka/server/config/KRaftConfigs.java:
##########
@@ -79,8 +77,7 @@ public class KRaftConfigs {
public static final String CONTROLLER_LISTENER_NAMES_CONFIG =
"controller.listener.names";
public static final String CONTROLLER_LISTENER_NAMES_DOC = "A
comma-separated list of the names of the listeners used by the controller. This
is required " +
- "if running in KRaft mode. When communicating with the controller
quorum, the broker will always use the first listener in this list.\n " +
- "Note: The ZooKeeper-based controller should not set this
configuration.";
+ "in KRaft mode. When communicating with the controller quorum, the
broker will always use the first listener in this list.";
Review Comment:
If we only have kraft mode, why do we need to say "in kraft mode"?
This implies there are other modes and is very confusing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
