ahuang98 commented on code in PR #18240:
URL: https://github.com/apache/kafka/pull/18240#discussion_r1917526506
##########
raft/src/test/java/org/apache/kafka/raft/RaftClientTestContext.java:
##########
@@ -197,9 +198,24 @@ public Builder(OptionalInt localId, Uuid localDirectoryId)
{
this.localDirectoryId = localDirectoryId;
}
+ public Builder(
+ ReplicaKey localKey,
+ VoterSet voters,
+ KRaftVersion kraftVersion
+ ) {
Review Comment:
I introduced this constructor to remove some of the redundancy and
conditionals I was seeing with test parameterization. Factoring in your next
comment as well, maybe it makes more sense to remove this constructor and have
a helper method do something similar instead in KafkaRaftClientPreVoteTest.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
