frankvicky commented on code in PR #17390:
URL: https://github.com/apache/kafka/pull/17390#discussion_r1917815997
##########
core/src/main/scala/kafka/log/LogCleanerManager.scala:
##########
@@ -533,21 +533,15 @@ private[log] class LogCleanerManager(val logDirs:
Seq[File],
def maintainUncleanablePartitions(): Unit = {
Review Comment:
`maintainUncleanablePartitions` is invoked by `CleanerThread#doWork`, which
is a daemon thread. It has been 愡widely tested through integration tests and
unit tests related to LogCleaner. IMHO, we can leverage these existing tests
and don't need to write new ones.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
