squah-confluent commented on code in PR #18499:
URL: https://github.com/apache/kafka/pull/18499#discussion_r1918460592
##########
coordinator-common/src/main/java/org/apache/kafka/coordinator/common/runtime/CoordinatorRuntime.java:
##########
@@ -840,7 +848,11 @@ private void failCurrentBatch(Throwable t) {
if (currentBatch != null) {
coordinator.revertLastWrittenOffset(currentBatch.baseOffset);
for (DeferredEvent event : currentBatch.deferredEvents) {
- event.complete(t);
+ try {
+ event.complete(t);
+ } catch (Throwable e) {
+ log.error("Event {} for {} failed to complete.",
event, tp, e);
+ }
Review Comment:
I'm very tempted to try something like this. Or maybe wrap each event in a
wrapper? Or have an abstract base class that does the catching and have the
concrete classes override a different method for their completions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
