frankvicky commented on code in PR #18389:
URL: https://github.com/apache/kafka/pull/18389#discussion_r1918784490
##########
bin/kafka-server-start.sh:
##########
@@ -19,6 +19,14 @@ then
echo "USAGE: $0 [-daemon] server.properties [--override
property=value]*"
exit 1
fi
+
+for arg in "$@"; do
+ if [[ "$arg" == *.properties ]]; then
+ [[ "$arg" == *"config/kraft"* ]] && echo "Warning: The 'config/kraft'
path has been removed. Now all configuration files are in 'config'."
Review Comment:
I agree on the trailing slash pattern. This would better distinguish
directories from files like `kraft*.properties.`
I will update it soon.
As for the warning, I also don't think it is necessary since the user might
put their config files wherever they want. But I'm open for this solution. If
we eventually want to keep this warning, we could make it more informative, as
mentioned before, it might catch the user custom path.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
