ahuang98 commented on code in PR #18240:
URL: https://github.com/apache/kafka/pull/18240#discussion_r1919024139
##########
checkstyle/suppressions.xml:
##########
@@ -187,6 +187,9 @@
<suppress checks="NPathComplexity"
files="(DynamicVoter|RecordsIterator).java"/>
+ <suppress checks="JavaNCSS"
+ files="(KafkaRaftClientTest).java"/>
+
Review Comment:
CI doesn't like the change either :(
```
Execution failed for task ':raft:checkstyleTest'.
> A failure occurred while executing
org.gradle.api.plugins.quality.internal.CheckstyleAction
> Checkstyle rule violations were found. See the report at:
file:///home/runner/work/kafka/kafka/raft/build/reports/checkstyle/test.html
Checkstyle files with violations: 1
Checkstyle violations by severity: [error:1]
```
I recall spending some time trying to debug the issue, and the potential fix
(SuppressionCommentFilter) seemed a bit more work than it was worth
JavaNCSS is mentioned in the existing Jira for addressing these Raft
suppressions though - https://issues.apache.org/jira/browse/KAFKA-18332
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
