jayteej commented on code in PR #18596:
URL: https://github.com/apache/kafka/pull/18596#discussion_r1920180748
##########
storage/src/test/java/org/apache/kafka/tiered/storage/utils/TieredStorageTestUtils.java:
##########
@@ -178,6 +178,8 @@ public static Map<String, String>
createTopicConfigForRemoteStorage(boolean enab
// a "small" number of records (i.e. such that the average record size
times the number of records is
// much less than the segment size), the number of records which hold
in a segment is the multiple of 12
// defined below.
+
+ // TODO: WIP - Need to consider options for dealing with this segment
roll approach not being valid for this PR.
topicProps.put(TopicConfig.SEGMENT_INDEX_BYTES_CONFIG,
String.valueOf(12 * maxRecordBatchPerSegment));
Review Comment:
@divijvaidya let's discuss how best to handle this please
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
