kirktrue commented on code in PR #18555:
URL: https://github.com/apache/kafka/pull/18555#discussion_r1920633122
##########
core/src/test/scala/integration/kafka/server/GssapiAuthenticationTest.scala:
##########
@@ -110,8 +110,8 @@ class GssapiAuthenticationTest extends
IntegrationTestHarness with SaslSetup {
* are able to connect after the second re-login. Verifies that logout is
performed only once
* since duplicate logouts without successful login results in NPE from Java
9 onwards.
*/
- @ParameterizedTest
- @ValueSource(strings = Array("kraft"))
+ @ParameterizedTest(name =
TestInfoUtils.TestWithParameterizedQuorumAndGroupProtocolNames)
+ @MethodSource(Array("getTestQuorumAndGroupProtocolParametersAll"))
def testLoginFailure(quorum: String): Unit = {
Review Comment:
This doesn't specify the groupProtocol in the parameter list. Shouldn't it?
##########
core/src/test/scala/integration/kafka/server/GssapiAuthenticationTest.scala:
##########
@@ -92,8 +92,8 @@ class GssapiAuthenticationTest extends IntegrationTestHarness
with SaslSetup {
* Tests that Kerberos replay error `Request is a replay (34)` is not
handled as an authentication exception
* since replay detection used to detect DoS attacks may occasionally reject
valid concurrent requests.
*/
- @ParameterizedTest
- @ValueSource(strings = Array("kraft"))
+ @ParameterizedTest(name =
TestInfoUtils.TestWithParameterizedQuorumAndGroupProtocolNames)
+ @MethodSource(Array("getTestQuorumAndGroupProtocolParametersAll"))
def testRequestIsAReplay(quorum: String): Unit = {
Review Comment:
This doesn't specify the groupProtocol in the parameter list. Shouldn't it?
##########
core/src/test/scala/integration/kafka/server/GssapiAuthenticationTest.scala:
##########
@@ -166,8 +166,8 @@ class GssapiAuthenticationTest extends
IntegrationTestHarness with SaslSetup {
* Tests that Kerberos error `Server not found in Kerberos database (7)` is
handled
* as a fatal authentication failure.
*/
- @ParameterizedTest
- @ValueSource(strings = Array("kraft"))
+ @ParameterizedTest(name =
TestInfoUtils.TestWithParameterizedQuorumAndGroupProtocolNames)
+ @MethodSource(Array("getTestQuorumAndGroupProtocolParametersAll"))
def testServerNotFoundInKerberosDatabase(quorum: String): Unit = {
Review Comment:
This doesn't specify the `groupProtocol` in the parameter list. Shouldn't it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
