jolshan commented on code in PR #18604:
URL: https://github.com/apache/kafka/pull/18604#discussion_r1920910617
##########
core/src/main/scala/kafka/log/UnifiedLog.scala:
##########
@@ -1052,7 +1057,7 @@ class UnifiedLog(@volatile var logStartOffset: Long,
}
private def batchMissingRequiredVerification(batch: MutableRecordBatch,
requestVerificationGuard: VerificationGuard): Boolean = {
-
producerStateManager.producerStateManagerConfig().transactionVerificationEnabled()
&& !batch.isControlBatch &&
+
producerStateManager.producerStateManagerConfig().transactionVerificationEnabled()
&&
Review Comment:
I moved the check to outside the if condition (short-circuiting the stament
before hasOngoingTransaction otherwise we can't write commit markers)
I can put this back, but it will just be a duplicate check.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
