ijuma commented on code in PR #18592:
URL: https://github.com/apache/kafka/pull/18592#discussion_r1921067305
##########
core/src/main/scala/kafka/log/LogManager.scala:
##########
@@ -1080,11 +1079,7 @@ class LogManager(logDirs: Seq[File],
log
}
- // When running a ZK controller, we may get a log that does not have a
topic ID. Assign it here.
- if (log.topicId.isEmpty) {
- topicId.foreach(log.assignTopicId)
- }
-
+
Review Comment:
Should we change the topid id so it's not optional?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
