chia7712 commented on code in PR #18566: URL: https://github.com/apache/kafka/pull/18566#discussion_r1922782866
########## core/src/main/scala/kafka/server/KafkaConfig.scala: ########## @@ -221,8 +213,6 @@ class KafkaConfig private(doLog: Boolean, val props: util.Map[_, _]) def quotaConfig: QuotaConfig = _quotaConfig /** ********* General Configuration ***********/ - val brokerIdGenerationEnable: Boolean = getBoolean(ServerConfigs.BROKER_ID_GENERATION_ENABLE_CONFIG) - val maxReservedBrokerId: Int = getInt(ServerConfigs.RESERVED_BROKER_MAX_ID_CONFIG) var brokerId: Int = getInt(ServerConfigs.BROKER_ID_CONFIG) Review Comment: Pull request #18478 removes the `broker.id` configuration, but this pull request does not. Should we continue treating `broker.id` as synonymous with node.id in Kafka version 4.x? The [documentation](https://kafka.apache.org/documentation/#brokerconfigs_node.id) states that `node.id` is mandatory when running in KRaft mode. Therefore, it's likely safe to remove `broker.id` from version 4.x, as Kafka servers in KRaft mode should already be configured with `node.id`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
