cmccabe commented on code in PR #18148:
URL: https://github.com/apache/kafka/pull/18148#discussion_r1926117043
##########
metadata/src/main/java/org/apache/kafka/controller/ConfigurationControlManager.java:
##########
@@ -165,7 +164,8 @@ private ConfigurationControlManager(LogContext logContext,
ConfigurationValidator validator,
Map<String, Object> staticConfig,
int nodeId,
- FeatureControlManager featureControl) {
Review Comment:
Can we just have a reference to `FeatureControlManager` inside
`ConfigurationControlManager`? We have that in other places and I think it
makes sense.
Feature control is the "bottom turtle" for all this stuff since things
behave differently based on features etc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
