chia7712 commented on code in PR #18654:
URL: https://github.com/apache/kafka/pull/18654#discussion_r1926464870


##########
docs/zk2kraft.html:
##########
@@ -155,14 +155,15 @@ <h5 class="anchor-heading">Removal metrics</h5>
         </li>
         <li>
             <p>
-                Remove the metrics which is monitoring the latency in 
milliseconds for ZooKeeper requests from broker.
+                Remove the metrics which are only used in ZooKeeper mode.
             </p>
             <ul>
                 
<li><code>kafka.server:type=ZooKeeperClientMetrics,name=ZooKeeperRequestLatencyMs</code></li>
+                
<li><code>kafka.controller:type=ControllerChannelManager</code></li>

Review Comment:
   #18658 add complete metrics, so I think PR should follow that pattern too.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to