chenyulin0719 commented on code in PR #18513:
URL: https://github.com/apache/kafka/pull/18513#discussion_r1926582730
##########
core/src/test/scala/integration/kafka/api/PlaintextAdminIntegrationTest.scala:
##########
@@ -1864,17 +1864,20 @@ class PlaintextAdminIntegrationTest extends
BaseAdminIntegrationTest {
val consumerSet = groupInstanceSet.map { groupInstanceId =>
createConsumer(configOverrides = createProperties(groupInstanceId))}
val topicSet = Set(testTopicName, testTopicName1, testTopicName2)
- val latch = new CountDownLatch(consumerSet.size)
+ val startLatch = new CountDownLatch(consumerSet.size)
Review Comment:
Hi @dajac, That make sense to me, the duplicated code isn't elegant. I
updated this PR and encapsulate the background polling threads to class
BackgroundConsumerThreadsManager, and expose below functions:
- startConsumerThreads
- stopConsumerThreads
- stopQuietly : thread/consumer cleanup .
The stopQuietly() replaced the 2 level try-catch in test. The test cases are
unchanged.
Please kindly let me know if I missed something.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
