frankvicky commented on code in PR #18621:
URL: https://github.com/apache/kafka/pull/18621#discussion_r1927012479
##########
core/src/main/java/kafka/server/builders/ReplicaManagerBuilder.java:
##########
@@ -130,36 +128,11 @@ public ReplicaManagerBuilder
setBrokerTopicStats(BrokerTopicStats brokerTopicSta
return this;
}
- public ReplicaManagerBuilder setIsShuttingDown(AtomicBoolean
isShuttingDown) {
- this.isShuttingDown = isShuttingDown;
- return this;
- }
-
- public ReplicaManagerBuilder
setDelayedProducePurgatory(DelayedOperationPurgatory<DelayedProduce>
delayedProducePurgatory) {
- this.delayedProducePurgatory = Optional.of(delayedProducePurgatory);
- return this;
- }
-
public ReplicaManagerBuilder
setDelayedFetchPurgatory(DelayedOperationPurgatory<DelayedFetch>
delayedFetchPurgatory) {
this.delayedFetchPurgatory = Optional.of(delayedFetchPurgatory);
return this;
}
- public ReplicaManagerBuilder
setDelayedRemoteFetchPurgatory(DelayedOperationPurgatory<DelayedRemoteFetch>
delayedRemoteFetchPurgatory) {
- this.delayedRemoteFetchPurgatory =
Optional.of(delayedRemoteFetchPurgatory);
- return this;
- }
-
- public ReplicaManagerBuilder
setDelayedDeleteRecordsPurgatory(DelayedOperationPurgatory<DelayedDeleteRecords>
delayedDeleteRecordsPurgatory) {
Review Comment:
You are right. These fields are something we miss and also need to be clean.
I will file a jira for this one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
