mimaison commented on code in PR #18519:
URL: https://github.com/apache/kafka/pull/18519#discussion_r1927186322
##########
clients/src/main/java/org/apache/kafka/common/security/oauthbearer/internals/secured/ConfigurationUtils.java:
##########
@@ -234,15 +237,15 @@ public <T> T get(String name) {
return (T) configs.get(name);
}
+ // visible for testing
// make sure the url is in the
"org.apache.kafka.sasl.oauthbearer.allowed.urls" system property
- public void throwIfURLIsNotAllowed(String urlConfig) {
- Set<String> allowedLoginModuleList = Arrays.stream(
+ void throwIfURLIsNotAllowed(String value) {
+ Set<String> allowedUrlsList = Arrays.stream(
Review Comment:
nit: it's a `Set` so not sure why we can it `List`, it could just be
`allowedUrls`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
