[ 
https://issues.apache.org/jira/browse/KAFKA-18634?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Colin McCabe updated KAFKA-18634:
---------------------------------
    Description: 
Fix several ELR metadata version issues for 4.0

- Several places in the code just check MetadataVersion.isElrSupported rather 
than looking at whether the eligible.leader.replicas.version feature is 
enabled. We need to check the feature and not do ELR stuff when ELR is turned 
off.

- The comment for MetadataVersion.IBP_4_0_IV1 should say which metadata records 
changed. Specifically, PartitionRecord, PartitionChangeRecord. It should also 
mention that ClearElrRecord was added in this MV.

- IBP_4_0_IV1 needs to be marked as stable.

We also need to decide if ELR turned on will be the default in 4.0 for new 
clusters, or an opt-in.

  was:
Fix several ELR metadata version issues for 4.0

- Several places in the code just check MetadataVersion.isElrSupported rather 
than looking at whether the eligible.leader.replicas.version feature is 
enabled. We need to check the feature and not do ELR stuff when ELR is turned 
off.

- The documentation for MetadataVersion.IBP_4_0_IV1 should say which metadata 
records changed. Specifically, PartitionRecord, PartitionChangeRecord. It 
should also mention that ClearElrRecord was added in this MV.

- IBP_4_0_IV1 needs to be marked as stable.

We also need to decide if ELR turned on will be the default in 4.0 for new 
clusters, or an opt-in.


> Fix ELR metadata version issues
> -------------------------------
>
>                 Key: KAFKA-18634
>                 URL: https://issues.apache.org/jira/browse/KAFKA-18634
>             Project: Kafka
>          Issue Type: Bug
>            Reporter: Colin McCabe
>            Assignee: Calvin Liu
>            Priority: Blocker
>
> Fix several ELR metadata version issues for 4.0
> - Several places in the code just check MetadataVersion.isElrSupported rather 
> than looking at whether the eligible.leader.replicas.version feature is 
> enabled. We need to check the feature and not do ELR stuff when ELR is turned 
> off.
> - The comment for MetadataVersion.IBP_4_0_IV1 should say which metadata 
> records changed. Specifically, PartitionRecord, PartitionChangeRecord. It 
> should also mention that ClearElrRecord was added in this MV.
> - IBP_4_0_IV1 needs to be marked as stable.
> We also need to decide if ELR turned on will be the default in 4.0 for new 
> clusters, or an opt-in.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to