frankvicky commented on code in PR #18687:
URL: https://github.com/apache/kafka/pull/18687#discussion_r1928822257
##########
core/src/main/java/kafka/server/builders/ReplicaManagerBuilder.java:
##########
@@ -164,23 +117,23 @@ public ReplicaManager build() {
time,
scheduler,
logManager,
- OptionConverters.toScala(remoteLogManager),
+ Option.empty(),
quotaManagers,
metadataCache,
logDirFailureChannel,
alterPartitionManager,
brokerTopicStats,
- isShuttingDown,
- OptionConverters.toScala(delayedProducePurgatory),
- OptionConverters.toScala(delayedFetchPurgatory),
-
OptionConverters.toScala(delayedDeleteRecordsPurgatory),
-
OptionConverters.toScala(delayedRemoteFetchPurgatory),
-
OptionConverters.toScala(delayedRemoteListOffsetsPurgatory),
-
OptionConverters.toScala(delayedShareFetchPurgatory),
- OptionConverters.toScala(threadNamePrefix),
- () -> brokerEpoch,
-
OptionConverters.toScala(addPartitionsToTxnManager),
- directoryEventHandler,
+ new AtomicBoolean(false),
+ Option.empty(),
Review Comment:
Hi @clolov
Thanks for the review.
Unfortunately, a few tests still use the constructor to send their test
purgatory instance, and these instances rely on MockTimer to conduct the test.
So I think we shouldn't not remove the constructor parameters at this moment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
