mumrah commented on code in PR #18644:
URL: https://github.com/apache/kafka/pull/18644#discussion_r1929256201
##########
clients/src/main/java/org/apache/kafka/clients/NetworkClient.java:
##########
@@ -1051,9 +1051,9 @@ private void
handleApiVersionsResponse(List<ClientResponse> responses,
apiVersionsResponse.data().finalizedFeaturesEpoch());
apiVersions.update(node, nodeVersionInfo);
this.connectionStates.ready(node);
- log.debug("Node {} has finalized features epoch: {}, finalized
features: {}, supported features: {}, ZK migration ready: {}, API versions:
{}.",
+ log.debug("Node {} has finalized features epoch: {}, finalized
features: {}, supported features: {}, API versions: {}.",
node, apiVersionsResponse.data().finalizedFeaturesEpoch(),
apiVersionsResponse.data().finalizedFeatures(),
- apiVersionsResponse.data().supportedFeatures(),
apiVersionsResponse.data().zkMigrationReady(), nodeVersionInfo);
Review Comment:
This field (ZkMigrationReady in ApiVersionsResponse) was last used in 3.6.
Starting in 3.7, we used the controller registration RPC in lieu of this field.
So, it seems a bit like dead code at this point. We should probably leave the
field in the RPC so we don't reuse the tagged field number, but we can set the
max versions to v4 and remove the usages in the non-generated code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
