frankvicky commented on PR #18702: URL: https://github.com/apache/kafka/pull/18702#issuecomment-2619541564
> The fetch improvements of [KAFKA-7109](https://issues.apache.org/jira/browse/KAFKA-7109) seems to just apply to the fetch requests on close the same timeout principle that was being applied to the coordinator close. According to the commit you mentioned, I think you are right. This behavior has existed for a long time and was recently applied to fetch requests on close at 3.5.0. > The change to the timeout behavior was introduced relatively recently in 3.5 via [KAFKA-7109](https://issues.apache.org/jira/browse/KAFKA-7109). Looking at https://github.com/apache/kafka/pull/12590, I'm not sure the change to ignore the user's timeout was necessarily intentional. > When closing, individual network requests should adhere to request.timeout.ms, but the overall timeout for closing should adhere to the user-provided timeout. This reminds me that the patch applied this close timeout principle to all closing behavior and I'm not sure if it is what we want. IIRC, classic consumer only used the timer for the coordinator and fetcher. 🤔 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
