apoorvmittal10 commented on code in PR #18696: URL: https://github.com/apache/kafka/pull/18696#discussion_r1935499733
########## core/src/main/java/kafka/server/share/SharePartition.java: ########## @@ -444,6 +450,11 @@ public CompletableFuture<Void> maybeInitialize() { stateEpoch = partitionData.stateEpoch(); List<PersisterStateBatch> stateBatches = partitionData.stateBatches(); + boolean isGapPresentInStateBatches = false; + // The previousBatchLastOffset is used to track the last offset of the previous batch. + // For the first batch that should ideally start from startOffset if there are no gaps, + // we assume the previousBatchLastOffset to be startOffset - 1. + long previousBatchLastOffset = startOffset - 1; Review Comment: Yeah, you are right. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org