bbejeck commented on code in PR #18721:
URL: https://github.com/apache/kafka/pull/18721#discussion_r1936292204


##########
streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamImpl.java:
##########
@@ -956,36 +956,36 @@ static <K1, V1, RN extends BaseRepartitionNode<K1, V1>> 
String createRepartition
     }
 
     @Override
-    public <VO, VR> KStream<K, VR> join(final KTable<K, VO> table,
-                                        final ValueJoiner<? super V, ? super 
VO, ? extends VR> joiner) {
+    public <VTable, VOut> KStream<K, VOut> join(final KTable<K, VTable> table,

Review Comment:
   Seems class could use a pass with `VTable -> TableValue` `VOut` probably 
self-explanatory though



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to