jolshan commented on code in PR #18720:
URL: https://github.com/apache/kafka/pull/18720#discussion_r1936496849
##########
core/src/main/scala/kafka/log/UnifiedLog.scala:
##########
@@ -569,20 +569,21 @@ class UnifiedLog(@volatile var logStartOffset: Long,
* Maybe create and return the VerificationGuard for the given producer ID
if the transaction is not yet ongoing.
* Creation starts the verification process. Otherwise return the sentinel
VerificationGuard.
*/
- def maybeStartTransactionVerification(producerId: Long, sequence: Int,
epoch: Short): VerificationGuard = lock synchronized {
+ def maybeStartTransactionVerification(producerId: Long, sequence: Int,
epoch: Short, isTV2: Boolean): VerificationGuard = lock synchronized {
Review Comment:
I left a few usages in tests since some of those are actually setting the
version to TV2. But all non-test usages (except for one in the client) are
changed. Let me know if you think that should be changed too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
