[ 
https://issues.apache.org/jira/browse/KAFKA-18697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17923177#comment-17923177
 ] 

Greg Harris commented on KAFKA-18697:
-------------------------------------

I think classes in the `connect-api` module should not be changed to Record 
types.

I'm not sure if class->record conversion breaks binary compatibility, but 
evolution of record classes appears to not be binary compatible in Section 
13.4.27 of the JLS: 
[https://docs.oracle.com/javase/specs/jls/se19/html/jls-13.html] 
So even if the conversion is binary compatible, changing those classes to 
record types would limit future evolution of those classes.

> Migrate suitable classes to records in connect module
> -----------------------------------------------------
>
>                 Key: KAFKA-18697
>                 URL: https://issues.apache.org/jira/browse/KAFKA-18697
>             Project: Kafka
>          Issue Type: Sub-task
>            Reporter: 黃竣陽
>            Assignee: 黃竣陽
>            Priority: Major
>
> We should change these class to Record
> SchemaAndValue, Field, OffsetSync, SourceAndTarget, Heartbeat, Checkpoint, 
> PluginSource, ConnectClusterDetailsImpl, TaskInfo, Message, LoggerLevel, 
> ErrorMessage, CreateConnectorRequest, ConnectorStateInfo, ConnectorOffsets, 
> ConnectorOffset, ConnectorInfo, ConfigValueInfo, ConfigKeyInfo, ConfigInfo, 
> ActiveTopicsInfo, ConnectRestExtensionContextImpl, RestartRequest, 
> ConnectorTaskId



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to