dajac commented on code in PR #18749:
URL: https://github.com/apache/kafka/pull/18749#discussion_r1939129722
##########
coordinator-common/src/main/java/org/apache/kafka/coordinator/common/runtime/CoordinatorRecordSerde.java:
##########
@@ -76,6 +76,11 @@ public CoordinatorRecord deserialize(
final ApiMessage valueMessage = apiMessageValueFor(recordType);
final short valueVersion = readVersion(valueBuffer, "value");
+
+ if (valueVersion < valueMessage.lowestSupportedVersion() ||
valueVersion > valueMessage.highestSupportedVersion()) {
+ throw new UnknownRecordVersionException(recordType, valueVersion);
+ }
Review Comment:
That's a good question. I think that we would need to do a new KIP or to
extend KIP-915: Txn and Group Coordinator Downgrade Foundation for this. In
KIP-915, we defined that using tagged fields should be the way forward to
handle backward compatibility. Hence, I am not sure that ignore newer version
is needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
