showuon commented on code in PR #18165:
URL: https://github.com/apache/kafka/pull/18165#discussion_r1939418180
##########
clients/src/test/java/org/apache/kafka/clients/admin/AdminClientUnitTestEnv.java:
##########
@@ -71,9 +71,13 @@ public AdminClientUnitTestEnv(Time time, Cluster cluster,
Map<String, Object> co
this.cluster = cluster;
AdminClientConfig adminClientConfig = new AdminClientConfig(config);
+ boolean usingBootstrapController = false;
+ if
(config.containsKey(AdminClientConfig.BOOTSTRAP_CONTROLLERS_CONFIG)) {
+ usingBootstrapController = true;
+ }
AdminMetadataManager metadataManager = new AdminMetadataManager(new
LogContext(),
adminClientConfig.getLong(AdminClientConfig.RETRY_BACKOFF_MS_CONFIG),
-
adminClientConfig.getLong(AdminClientConfig.METADATA_MAX_AGE_CONFIG), false);
+
adminClientConfig.getLong(AdminClientConfig.METADATA_MAX_AGE_CONFIG),
usingBootstrapController);
Review Comment:
Good suggestion. Updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
