TaiJuWu commented on code in PR #18799:
URL: https://github.com/apache/kafka/pull/18799#discussion_r1941124947
##########
clients/src/main/java/org/apache/kafka/common/utils/Utils.java:
##########
@@ -94,12 +94,14 @@ public final class Utils {
private Utils() {}
- // This matches URIs of formats: host:port and protocol://host:port
+ // This matches URIs of formats: host:port
// IPv6 is supported with [ip] pattern
private static final Pattern HOST_PORT_PATTERN =
Pattern.compile("^(?:[0-9a-zA-Z\\-%._]*://)?\\[?([0-9a-zA-Z\\-%._:]*)]?:([0-9]+)");
Review Comment:
This pattern easy make breaking change so I don't touch this one.
By the way, there is similar RE within
https://github.com/apache/kafka/blob/d0bca67b27476a30c462a6bb3c172daa37367a4e/server/src/main/java/org/apache/kafka/network/SocketServerConfigs.java#L175-L176
Maybe we can unify them in 5.0.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
