frankvicky commented on code in PR #18702: URL: https://github.com/apache/kafka/pull/18702#discussion_r1941409678
########## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java: ########## @@ -1368,6 +1373,10 @@ private void close(Duration timeout, boolean swallowException) { } } + private Timer createTimer(Duration timeout) { Review Comment: Yes, it is nice to follow the style of classic consumers. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org