ijuma commented on code in PR #18801:
URL: https://github.com/apache/kafka/pull/18801#discussion_r1941423335
##########
core/src/main/scala/kafka/server/metadata/KRaftMetadataCache.scala:
##########
@@ -345,68 +344,69 @@ class KRaftMetadataCache(
Option(_currentImage.cluster.broker(brokerId)).count(_.inControlledShutdown) ==
1
}
- override def getAliveBrokers(): Iterable[BrokerMetadata] =
getAliveBrokers(_currentImage)
+ override def getAliveBrokers(): util.List[BrokerMetadata] =
getAliveBrokers(_currentImage)
- private def getAliveBrokers(image: MetadataImage): Iterable[BrokerMetadata]
= {
+ private def getAliveBrokers(image: MetadataImage): util.List[BrokerMetadata]
= {
image.cluster().brokers().values().asScala.filterNot(_.fenced()).
map(b => new BrokerMetadata(b.id, b.rack))
- }
+ }.toList.asJava
- override def getAliveBrokerNode(brokerId: Int, listenerName: ListenerName):
Option[Node] = {
- Option(_currentImage.cluster().broker(brokerId)).filterNot(_.fenced()).
- flatMap(_.node(listenerName.value()).toScala)
+ override def getAliveBrokerNode(brokerId: Int, listenerName: ListenerName):
util.Optional[Node] = {
+ util.Optional.ofNullable(_currentImage.cluster().broker(brokerId))
+ .filter(broker => !broker.fenced())
+ .flatMap(broker => broker.node(listenerName.value()))
}
- override def getAliveBrokerNodes(listenerName: ListenerName): Seq[Node] = {
+ override def getAliveBrokerNodes(listenerName: ListenerName):
util.List[Node] = {
_currentImage.cluster().brokers().values().asScala.filterNot(_.fenced()).
- flatMap(_.node(listenerName.value()).toScala).toSeq
+ flatMap(_.node(listenerName.value()).toScala).toList.asJava
Review Comment:
Note that `toList` converts to an immutable linked list - you do _not_ want
to do that if you are then calling `asJava`. `toBuffer` is probably a better
option.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
