lianetm commented on code in PR #18777:
URL: https://github.com/apache/kafka/pull/18777#discussion_r1941488787
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerMetadata.java:
##########
@@ -94,6 +95,15 @@ protected synchronized boolean retainTopic(String topic,
boolean isInternal, lon
if (isInternal && !includeInternalTopics)
return false;
+ // Keep leader metadata for topics matching the RE2J subscription.
+ // We aim to replaced this with something more efficient in
KAFKA-18117.
Review Comment:
Totally agree, my point was only that it's not going to get better with
KAFKA-18117 directly, we need something else.
We currently don't have the state needed to be able to check topics assigned
from regex (not topic partitions assigned from regex), so I will file a
separate jira to address that and be able to improve this further.
Given that the check is performed only if RE2J in use, and over the set of
partitions assigned to a single consumer, I would say it's ok to include it in
4.1 (not 4.0 blocker). What do you think?
--- Jira
https://issues.apache.org/jira/browse/KAFKA-18729
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
