brandboat commented on code in PR #18189: URL: https://github.com/apache/kafka/pull/18189#discussion_r1942084278
########## core/src/test/scala/integration/kafka/server/KRaftClusterTest.scala: ########## @@ -696,7 +696,8 @@ class KRaftClusterTest { new AlterConfigOp(new ConfigEntry("max.connections.per.ip", "60"), OpType.SET)))))) validateConfigs(admin, Map(new ConfigResource(Type.BROKER, "") -> Seq( ("log.roll.ms", "1234567"), - ("max.connections.per.ip", "60"))), exhaustive = true) + ("max.connections.per.ip", "60"), + ("min.insync.replicas", "1"))), exhaustive = true) Review Comment: after https://github.com/apache/kafka/commit/ec49a60e4f690f311060045ee1feb20d99837f97, if ELR is enabled, a cluster-level min.insync.replicas will be set to 1, and this PR will enable ELR by default in all integration tests that use TestKitNodes.java -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org