ijuma commented on PR #18783: URL: https://github.com/apache/kafka/pull/18783#issuecomment-2637047546
I asked this in another similar PR, but how are we verifying that it's safe to make these changes? Also, for critical classes like `TopicIdPartition`, we need to verify there is no perf regression when it comes to `equals`/`hashCode` as these classes are used in hot paths as HashMap keys. To be clear, I'm not saying these changes are not good, but we need to do the due diligence since records have a specific behavior that may not be the same as the existing classes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
