CalvinConfluent commented on code in PR #18810:
URL: https://github.com/apache/kafka/pull/18810#discussion_r1943845486
##########
core/src/main/scala/kafka/server/ReplicaManager.scala:
##########
@@ -790,18 +790,49 @@ class ReplicaManager(val config: KafkaConfig,
return
}
+ // Wrap the callback to be handled on an arbitrary request handler thread
+ // when transaction verification is complete. The request local passed in
+ // is only used when the callback is executed immediately.
+ val wrappedPostVerificationCallback =
KafkaRequestHandler.wrapAsyncCallback(
+ postVerificationCallback,
+ requestLocal
+ )
+
+ val retryTimeoutMs =
config.addPartitionsToTxnConfig.addPartitionsToTxnMaxTimeoutMs()
Review Comment:
I think using the request timeout is good enough.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
