chia7712 commented on code in PR #18547:
URL: https://github.com/apache/kafka/pull/18547#discussion_r1944140562
##########
core/src/test/scala/unit/kafka/server/KafkaConfigTest.scala:
##########
@@ -49,6 +49,17 @@ import org.junit.jupiter.api.function.Executable
import scala.jdk.CollectionConverters._
class KafkaConfigTest {
+
+ def createDefaultConfig(): Properties = {
+ val props = new Properties()
+ props.setProperty(KRaftConfigs.PROCESS_ROLES_CONFIG, "broker,controller")
+ props.setProperty(KRaftConfigs.CONTROLLER_LISTENER_NAMES_CONFIG,
"CONTROLLER")
+ props.setProperty(KRaftConfigs.NODE_ID_CONFIG, "1")
+ props.setProperty(SocketServerConfigs.LISTENERS_CONFIG,
"PLAINTEXT://localhost:0,CONTROLLER://localhost:5000")
+ props.setProperty(QuorumConfig.QUORUM_VOTERS_CONFIG, "2@localhost:5000")
Review Comment:
this config is invalid. It uses combined mode so the id should be aligned
with `node.id`. `2@localhost:5000` -> `1@localhost:5000` - otherwise, the test
cases using this config will always get invalid `KafkaConfig`
@mingyen066 Could you please file a minor to fix it? @m1a2st is busy today
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
