chia7712 commented on code in PR #18641: URL: https://github.com/apache/kafka/pull/18641#discussion_r1944148844
########## core/src/main/scala/kafka/server/ClientQuotaManager.scala: ########## @@ -418,14 +421,11 @@ class ClientQuotaManager(private val config: ClientQuotaManagerConfig, */ lock.writeLock().lock() try { - val userEntity = sanitizedUser.map { - case ZooKeeperInternals.DEFAULT_STRING => DefaultUserEntity - case user => UserEntity(user) - } - val clientIdEntity = sanitizedClientId.map { - case ZooKeeperInternals.DEFAULT_STRING => DefaultClientIdEntity - case _ => ClientIdEntity(clientId.getOrElse(throw new IllegalStateException("Client-id not provided"))) + val clientIdEntity = clientEntity match { Review Comment: we don't need this conversion, right? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org