apoorvmittal10 opened a new pull request, #18826: URL: https://github.com/apache/kafka/pull/18826
The PR does the following: - Refactors ShareGroupMetrics out of SharePartitionManager as there are additional metrics need to be defined, as per KIP-1103, where ShareGroupMetrics is required to be pass to DelayedShareFetch, etc. - As the KIP-1103 defines metrics which are Histogram in ShareGroupMetrics, also the BrokerTopicMetrics are Yammer metrics hence to maintian consistency, I moved existing ShareGroupMetrics (defined in KIP-932) also to Yammer metrics following Yammer metrics group naming convention i.e. from share-group-metrics to ShareGroupMetrics (this will require KIP-932 upadate where `share-acknowledgement` metric is already moved to BrokerTopicMetrics and other 2 in this PR to Yammer metrics). - Moved `record-acknowledgement-rate|count` to Yammer meter metric with name `RecordAcknowledgementPerSec`. - Moved `partition-load-time-avg|max` to Yammer histogram metric with name `PartitionLoadTimeMs`. - Corrects the way partition load time metrics was calculated. The load time of share partition should be considered when the state of share partition moves from `empty` which happens once mayBeInitialize finishes. The existing implementation is not much helpful now since share partition initialization is now async, at the time of this metric implementation the initialization of share partition was sync hence the metric needed correction. This PR is first step to start implementing other ShareGroupMetrics as defined in KIP-1103. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
