bbejeck commented on code in PR #18827:
URL: https://github.com/apache/kafka/pull/18827#discussion_r1946820697
##########
clients/src/test/java/org/apache/kafka/clients/consumer/internals/StreamsGroupHeartbeatRequestManagerTest.java:
##########
@@ -352,6 +370,14 @@ void testSuccessfulResponse() {
assertEquals(data.activeTasks(), response.activeTasks());
assertEquals(data.standbyTasks(), response.standbyTasks());
assertEquals(data.warmupTasks(), response.warmupTasks());
+
+ assertEquals(data.partitionsByUserEndpoint(),
response.partitionsByUserEndpoint());
+ Map<StreamsAssignmentInterface.HostInfo,
StreamsAssignmentInterface.EndpointPartitions> endpointPartitionsMap =
streamsAssignmentInterface.partitionsByHost.get();
+ assertEquals(endpointPartitionsMap.size(),
response.partitionsByUserEndpoint().size());
+ StreamsAssignmentInterface.HostInfo hostInfo =
endpointPartitionsMap.keySet().iterator().next();
+ assertEquals(hostInfo.host, endpoint.host());
+ assertEquals(hostInfo.port, endpoint.port());
+ StreamsAssignmentInterface.EndpointPartitions endpointPartitions =
endpointPartitionsMap.get(hostInfo);
Review Comment:
good catch, but I left it there on purpose, it'll be used in the test when
PR gets updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
