chia7712 commented on code in PR #18803: URL: https://github.com/apache/kafka/pull/18803#discussion_r1946881984
########## server/src/main/java/org/apache/kafka/network/EndPoint.java: ########## @@ -0,0 +1,104 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.kafka.network; + +import org.apache.kafka.common.KafkaException; +import org.apache.kafka.common.network.ListenerName; +import org.apache.kafka.common.security.auth.SecurityProtocol; +import org.apache.kafka.common.utils.Utils; + +import java.util.Locale; +import java.util.Objects; + +public class EndPoint { Review Comment: > It's a bit weird to have these 2 classes almost identical. I agree that duplicate code is annoying., but there's another concern. The `Endpoint#listenerName()` method returns an Optional object. If we utilize Endpoint on the server-side, this could lead to frequent calls to `listenerName().get()`. To avoid duplicate code, we might consider using the record class to streamline the handling of `Endpoint` on the server-side. I've noticed that `Endpoint#listenerName` does not appear to return `Optional.empty` in the current implementation. I haven't been able to find any scenarios where an `Endpoint` is created with a null listener name. Therefore, I suggest filing a follow-up (a smaller KIP) to revise the public APIs and remove the Optional type for `listenerName`. This change would also allow us to eliminate the duplicate class as suggested by @mimaison. @mimaison @TaiJuWu WDYT? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
