frankvicky commented on code in PR #18737:
URL: https://github.com/apache/kafka/pull/18737#discussion_r1947492932
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ShareMembershipManager.java:
##########
@@ -117,6 +117,14 @@ public String rackId() {
return rackId;
}
+ @Override
+ public NetworkClientDelegate.PollResult poll(long currentTimeMs) {
+ if (state == MemberState.RECONCILING) {
+ maybeReconcile(true);
+ }
+ return NetworkClientDelegate.PollResult.EMPTY;
+ }
+
Review Comment:
ShareMembershipManager will be affected if we add a new argument to
`maybeReconcile`, so I override the `poll` method for it to keep the original
logic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
