chia7712 commented on PR #18760: URL: https://github.com/apache/kafka/pull/18760#issuecomment-2648206457
This PR is great and has given me an idea for improving our CI process. This PR introduce a java doc error, and hence QA does not run `streams:test`. ``` 2025-02-05T05:09:25.4676334Z /home/runner/work/kafka/kafka/streams/src/main/java/org/apache/kafka/streams/kstream/KStream.java:694: warning: invalid usage of tag {@link #to(String). 2025-02-05T05:09:25.4677773Z 2025-02-05T05:09:25.4692001Z * See {@link #to(String).} 2025-02-05T05:09:25.4692476Z > Task :streams:javadoc FAILED 2025-02-05T05:09:25.4693167Z ^ 2025-02-05T05:09:25.4694441Z /home/runner/work/kafka/kafka/streams/src/main/java/org/apache/kafka/streams/kstream/KStream.java:694: warning: invalid usage of tag {@link #to(String). 2025-02-05T05:09:25.4695730Z * See {@link #to(String).} 2025-02-05T05:09:25.4696252Z ^ 2025-02-05T05:09:25.4697406Z /home/runner/work/kafka/kafka/streams/src/main/java/org/apache/kafka/streams/kstream/KStream.java:694: warning: invalid usage of tag {@link #to(String). 2025-02-05T05:09:25.4698737Z * See {@link #to(String).} 2025-02-05T05:09:25.4699299Z ^ ``` By contrast, `quarantinedTest` is still executable because `quarantinedTest` does not depend on `javadoc` https://github.com/apache/kafka/blob/trunk/build.gradle#L710 Although #18838 resolves the current doc error, I believe we should enhance our CI to prevent similar issues from occurring in the future. To be honest, it is too hard to request reviewers to check all contents of CI. Maybe we can add `javadoc` to the build phase which is similar to #18183. @mumrah WDYT? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org