ijuma commented on code in PR #18820:
URL: https://github.com/apache/kafka/pull/18820#discussion_r1949458417
##########
core/src/test/scala/unit/kafka/server/ReplicaFetcherThreadTest.scala:
##########
@@ -90,7 +90,7 @@ class ReplicaFetcherThreadTest {
val logContext = new LogContext(s"[ReplicaFetcher
replicaId=${brokerConfig.brokerId},
leaderId=${leaderEndpointBlockingSend.brokerEndPoint().id},
fetcherId=$fetcherId] ")
val fetchSessionHandler = new FetchSessionHandler(logContext,
leaderEndpointBlockingSend.brokerEndPoint().id)
val leader = new RemoteLeaderEndPoint(logContext.logPrefix,
leaderEndpointBlockingSend, fetchSessionHandler,
- brokerConfig, replicaMgr, quota, () =>
brokerConfig.interBrokerProtocolVersion, () => 1)
+ brokerConfig, replicaMgr, quota, () =>
MetadataVersion.MINIMUM_KRAFT_VERSION, () => 1)
Review Comment:
Is the parameter still useful? Same question for places where we are now
hardcoding the value.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
