apoorvmittal10 commented on code in PR #18833:
URL: https://github.com/apache/kafka/pull/18833#discussion_r1949587802
##########
core/src/main/scala/kafka/server/BrokerServer.scala:
##########
@@ -803,7 +807,7 @@ class BrokerServer(
if (clientToControllerChannelManager != null)
CoreUtils.swallow(clientToControllerChannelManager.shutdown(), this)
- if (logManager != null)
+ if (logManager != null && lifecycleManager != null)
Review Comment:
Will it be safe to pass `-1` as broker epoch to `logManager.shutdown` as the
broker is not compeletely instantiated?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
