AndrewJSchofield commented on code in PR #18829:
URL: https://github.com/apache/kafka/pull/18829#discussion_r1950538401
##########
tests/kafkatest/services/kafka/kafka.py:
##########
@@ -778,6 +790,13 @@ def prop_file(self, node):
for prop in self.per_node_server_prop_overrides.get(self.idx(node),
[]):
override_configs[prop[0]] = prop[1]
+ if self.use_share_groups is not None and self.use_share_groups is True:
+ override_configs[config_property.SHARE_GROUP_ENABLE] =
str(self.use_share_groups)
+ override_configs[config_property.UNSTABLE_API_VERSIONS_ENABLE] =
str(self.use_share_groups)
+
override_configs[config_property.GROUP_COORDINATOR_REBALANCE_PROTOCOLS] =
'classic,consumer,share'
+
override_configs[config_property.SHARE_COORDINATOR_STATE_TOPIC_REPLICATION_FACTOR]
= str(min(self.num_nodes, 3))
Review Comment:
I wonder why it is necessary to set the replication factor and min-isr for
the share-state topic in this manner. I would have thought that the logic for
setting values for the consumer-offsets and transaction-state topics would be
the same as needed for the share-state topic. Please investigate more.
Personally, I think the `use_share_groups` setting should just turn on the
configs needed to turn on share groups.
##########
tests/kafkatest/services/kafka/kafka.py:
##########
@@ -206,7 +206,8 @@ def __init__(self, context, num_nodes, zk,
security_protocol=SecurityConfig.PLAI
use_new_coordinator=None,
consumer_group_migration_policy=None,
dynamicRaftQuorum=False,
- use_transactions_v2=False
+ use_transactions_v2=False,
+ use_share_groups=None,
Review Comment:
nit: Extraneous comma
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
