mjsax commented on code in PR #18867:
URL: https://github.com/apache/kafka/pull/18867#discussion_r1952161404
##########
streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamImpl.java:
##########
@@ -1095,9 +1080,6 @@ private <VTable, VOut> KStream<K, VOut>
doStreamTableJoin(final KTable<K, VTable
final
ValueJoinerWithKey<? super K, ? super V, ? super VTable, ? extends VOut> joiner,
final
JoinedInternal<K, V, VTable> joinedInternal,
final boolean
leftJoin) {
- Objects.requireNonNull(table, "table can't be null");
- Objects.requireNonNull(joiner, "joiner can't be null");
Review Comment:
Unnecessary -- this is checked in callee method already (and we need to keep
it in the callees and cannot pull it in here)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
